Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yael-Starkware)

crates/papyrus_storage/src/utils.rs line 13 at r1 (raw file):

use crate::{open_storage, StorageConfig, StorageResult, StorageTxn};

/// dumps a table from the storage to a file in JSON format

Fix grammar - Capitalize first word, put "." at end of sentence. (x2)

crates/papyrus_storage/src/utils.rs line 26 at r1 (raw file):

    let mut cursor = table_handle.cursor(&txn.txn)?;
    let iter = DbIter::new(&mut cursor);
    let file = File::create(file_path)?;

what happens if the file already exists?
what happens if the directory doesn't exist?
do we want to handle / document faulty scenarios?

crates/papyrus_storage/src/utils.rs line 41 at r1 (raw file):

}

/// dumps the declared classes table from the storage to a file

declared_classes

Code quote:

declared classes

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @OmriEshhar1)

crates/papyrus_storage/src/utils.rs line 13 at r1 (raw file):

Done.

crates/papyrus_storage/src/utils.rs line 26 at r1 (raw file):

if the file exists then it's content will be reset.
id a directory doesn't exist, the error will be passed with the ? operator.
any faulty scenario is returned from the function. I will make sure to print the error clearly in the main function.

crates/papyrus_storage/src/utils.rs line 41 at r1 (raw file):

Done.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)